diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 593187e406..d714c300ec 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -164,7 +164,6 @@ Naming/HeredocDelimiterNaming: Naming/InclusiveLanguage: CheckStrings: true FlaggedTerms: - # TODO: If possible, make this stricter. slave: AllowedRegex: - "gitslave" # Used in formula `gitslave` @@ -392,12 +391,12 @@ Style/NumericLiterals: Exclude: - "**/Brewfile" -# TODO: These are pre-existing violations and should be corrected -# to define methods so that call sites can be type-checked. Style/OpenStructUse: Exclude: - - "Homebrew/cli/args.rb" - "Taps/**/*.rb" + # TODO: This is a pre-existing violation and should be corrected + # to define methods so that call sites can be type-checked. + - "Homebrew/cli/args.rb" # Rescuing `StandardError` is an understood default. Style/RescueStandardError: diff --git a/Library/Homebrew/cmd/fetch.rb b/Library/Homebrew/cmd/fetch.rb index 569239ad19..ade3a21553 100644 --- a/Library/Homebrew/cmd/fetch.rb +++ b/Library/Homebrew/cmd/fetch.rb @@ -116,7 +116,6 @@ module Homebrew begin formula.clear_cache if args.force? - # TODO: Deprecate `--bottle-tag`. bottle_tag = if (bottle_tag = args.bottle_tag&.to_sym) Utils::Bottles::Tag.from_symbol(bottle_tag) else diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index 85807993b8..460fe6c1c9 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -74,14 +74,22 @@ class AbstractDownloadStrategy # Disable any output during downloading. # - # TODO: Deprecate once we have an explicitly documented alternative. - # # @api public sig { void } - def shutup! + def quiet! @quiet = true end + # Disable any output during downloading. + # + # @deprecated + # @api private + sig { void } + def shutup! + # odeprecated "AbstractDownloadStrategy#shutup!", "AbstractDownloadStrategy#quiet!" + quiet! + end + def quiet? Context.current.quiet? || @quiet end