admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: add npm path nudge

Browse Source
This commit is contained in:
Dominyk Tiller 2015-06-09 15:52:26 +01:00
parent be9c5d5d16
commit f63e7a92bb
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Library/Homebrew/cmd/audit.rb
View File

@ -489,6 +489,17 @@ class FormulaAuditor
if text =~ /Formula\.factory\(/ if text =~ /Formula\.factory\(/
problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\"" problem "\"Formula.factory(name)\" is deprecated in favor of \"Formula[name]\""
end end
if text =~ /system "npm", "install"/ && text !~ %r[opt_libexec}/npm/bin]
need_npm = "\#{Formula[\"node\"].opt_libexec\}/npm/bin"
problem <<-EOS.undent
Please add ENV.prepend_path \"PATH\", \"#{need_npm}"\ to def install
EOS
end
if text =~ /system "npm", "install"/ && text !~ /"HOME"/
problem "Please add ENV[\"HOME\"] = buildpath/\".brew_home\" to def install"
end
end end
def audit_line(line, lineno) def audit_line(line, lineno)