admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

brew pull: enable blocking bintray publish by setting content-type

Browse Source 
Looks like the bintray publish_wait_for_secs was being ignored because the
content type wasn't being set, so it defaulted to x-www-form-urlencoded
instead of application/json.

Changes the  timeout to 0 to preserve current non-blocking behavior, which
we want in case multiple formulae are being updated.

Closes Homebrew/homebrew#49951.

Signed-off-by: Andrew Janke <andrew@apjanke.net>
This commit is contained in:
Andrew Janke 2016-03-10 00:56:32 -05:00 committed by Xu Cheng
parent 2c3a7e8c75
commit f63b4359d7
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/cmd/pull.rb
View File

@ -194,7 +194,8 @@ module Homebrew
version = f.pkg_version version = f.pkg_version
curl "-w", '\n', "--silent", "--fail", curl "-w", '\n', "--silent", "--fail",
"-u#{bintray_user}:#{bintray_key}", "-X", "POST", "-u#{bintray_user}:#{bintray_key}", "-X", "POST",
"-d", '{"publish_wait_for_secs": -1}', "-H", "Content-Type: application/json",
"-d", '{"publish_wait_for_secs": 0}',
"https://api.bintray.com/content/homebrew/#{repo}/#{package}/#{version}/publish" "https://api.bintray.com/content/homebrew/#{repo}/#{package}/#{version}/publish"
bintray_fetch_formulae << f bintray_fetch_formulae << f
end end