admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bump-formula-pr: audit formula before opening PR

Browse Source
This commit is contained in:
ilovezfs 2016-06-17 10:10:47 -07:00
parent 327f5ca177
commit f5a462bca1
1 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Library/Homebrew/dev-cmd/bump-formula-pr.rb
View File

@ -1,5 +1,5 @@
#: * `bump-formula-pr` [`--devel`] [`--dry-run`] `--url=`<url> `--sha256=`<sha-256> <formula>: #: * `bump-formula-pr` [`--devel`] [`--dry-run`] [`--audit`|`--strict`] `--url=`<url> `--sha256=`<sha-256> <formula>:
#: * `bump-formula-pr` [`--devel`] [`--dry-run`] `--tag=`<tag> `--revision=`<revision> <formula>: #: * `bump-formula-pr` [`--devel`] [`--dry-run`] [`--audit`|`--strict`] `--tag=`<tag> `--revision=`<revision> <formula>:
#: Creates a pull request to update the formula with a new url or a new tag. #: Creates a pull request to update the formula with a new url or a new tag.
#: #:
#: If a <url> is specified, the <sha-256> checksum of the new download must #: If a <url> is specified, the <sha-256> checksum of the new download must
@ -13,6 +13,10 @@
#: #:
#: If `--dry-run` is passed, print what would be done rather than doing it. #: If `--dry-run` is passed, print what would be done rather than doing it.
#: #:
#: If `--audit` is passed, run `brew audit` before opening the PR.
#:
#: If `--strict` is passed, run `brew audit --strict` before opening the PR.
#:
#: Note that this command cannot be used to transition a formula from a #: Note that this command cannot be used to transition a formula from a
#: url-and-sha256 style specification into a tag-and-revision style #: url-and-sha256 style specification into a tag-and-revision style
#: specification, nor vice versa. It must use whichever style specification #: specification, nor vice versa. It must use whichever style specification
@ -113,22 +117,47 @@ module Homebrew
] ]
end end
backup_file = File.read(formula.path) unless ARGV.dry_run?
new_contents = inreplace_pairs(formula.path, replacement_pairs) new_contents = inreplace_pairs(formula.path, replacement_pairs)
new_formula_version = formula_version(formula, requested_spec, new_contents) new_formula_version = formula_version(formula, requested_spec, new_contents)
if new_formula_version < old_formula_version if new_formula_version < old_formula_version
formula.path.atomic_write(backup_file) unless ARGV.dry_run?
odie <<-EOS.undent odie <<-EOS.undent
You probably need to bump this formula manually since changing the You probably need to bump this formula manually since changing the
version from #{old_formula_version} to #{new_formula_version} would be a downgrade. version from #{old_formula_version} to #{new_formula_version} would be a downgrade.
EOS EOS
elsif new_formula_version == old_formula_version elsif new_formula_version == old_formula_version
formula.path.atomic_write(backup_file) unless ARGV.dry_run?
odie <<-EOS.undent odie <<-EOS.undent
You probably need to bump this formula manually since the new version You probably need to bump this formula manually since the new version
and old version are both #{new_formula_version}. and old version are both #{new_formula_version}.
EOS EOS
end end
if ARGV.dry_run?
if ARGV.include? "--strict"
ohai "brew audit --strict #{formula.path.basename}"
elsif ARGV.include? "--audit"
ohai "brew audit #{formula.path.basename}"
end
else
failed_audit = false
if ARGV.include? "--strict"
system HOMEBREW_BREW_FILE, "audit", "--strict", formula.path
failed_audit = !$?.success?
elsif ARGV.include? "--audit"
system HOMEBREW_BREW_FILE, "audit", formula.path
failed_audit = !$?.success?
end
if failed_audit
formula.path.atomic_write(backup_file)
odie "brew audit failed!"
end
end
unless Formula["hub"].any_version_installed? unless Formula["hub"].any_version_installed?
if ARGV.dry_run? if ARGV.dry_run?
ohai "brew install hub" ohai "brew install hub"