From f52fbaf917391eea82b360bc42654c9219f60843 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 8 Mar 2023 00:29:47 +0000 Subject: [PATCH] rubocop: Drop "ff" from `Naming/MethodParameterName` allowlist - It seems that "ff" was short for plural formula, so formulae. --- Library/.rubocop.yml | 1 - Library/Homebrew/diagnostic.rb | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 4e029176cf..5d0f41d952 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -195,7 +195,6 @@ Naming/MethodParameterName: "c2", "e", "f", - "ff", "o", "pr", ] diff --git a/Library/Homebrew/diagnostic.rb b/Library/Homebrew/diagnostic.rb index 3d1c512a22..821564e658 100644 --- a/Library/Homebrew/diagnostic.rb +++ b/Library/Homebrew/diagnostic.rb @@ -17,9 +17,9 @@ module Homebrew # # @api private module Diagnostic - def self.missing_deps(ff, hide = nil) + def self.missing_deps(formulae, hide = nil) missing = {} - ff.each do |f| + formulae.each do |f| missing_dependencies = f.missing_dependencies(hide: hide) next if missing_dependencies.empty?