From f3ef9a4551ea05e014a3b0cd4ce22624444bdbaf Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Fri, 23 Sep 2016 00:13:04 +0100 Subject: [PATCH] diagnostic: make using outdated dev tools fatal A smarter form of https://github.com/Homebrew/brew/commit/559cea7fa9d7f9f2557f2523092687dec45c5316. Travis users can't force Travis to update 10.11 to Xcode 8, so this was murdering builds left, right & centre. Fixes https://github.com/Homebrew/brew/issues/1096 whilst still retaining the point of the original commit. Also offers developers an opt-out so if we need to test something on 10.11 with Xcode 7.x we can, etc. --- Library/Homebrew/extend/os/mac/diagnostic.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/extend/os/mac/diagnostic.rb b/Library/Homebrew/extend/os/mac/diagnostic.rb index 15dd3328fe..ba80cbc78b 100644 --- a/Library/Homebrew/extend/os/mac/diagnostic.rb +++ b/Library/Homebrew/extend/os/mac/diagnostic.rb @@ -14,13 +14,13 @@ module Homebrew end def fatal_development_tools_checks - if MacOS.prerelease? + if ENV["TRAVIS"] || ARGV.homebrew_developer? %w[ - check_xcode_up_to_date - check_clt_up_to_date ] else %w[ + check_xcode_up_to_date + check_clt_up_to_date ] end end