admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Resolve utils/analytics_spec violation

Browse Source
This commit is contained in:
Douglas Eichelberger 2023-01-22 17:08:50 -08:00
parent 0bfcf91a16
commit f365870a42
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/test/utils/analytics_spec.rb
View File

@ -143,7 +143,7 @@ describe Utils::Analytics do
context "when formula does not have a tap" do context "when formula does not have a tap" do
let(:err) { BuildError.new(f, "badprg", %w[arg1 arg2], {}) } let(:err) { BuildError.new(f, "badprg", %w[arg1 arg2], {}) }
let(:f) { double(Formula, name: "foo", path: "blah", tap: nil) } let(:f) { instance_double(Formula, name: "foo", path: "blah", tap: nil) }
it "does not report event if BuildError is raised" do it "does not report event if BuildError is raised" do
expect(described_class).not_to receive(:report_event) expect(described_class).not_to receive(:report_event)
@ -153,7 +153,7 @@ describe Utils::Analytics do
context "when tap for a formula is not installed" do context "when tap for a formula is not installed" do
let(:err) { BuildError.new(f, "badprg", %w[arg1 arg2], {}) } let(:err) { BuildError.new(f, "badprg", %w[arg1 arg2], {}) }
let(:f) { double(Formula, name: "foo", path: "blah", tap: CoreTap.instance) } let(:f) { instance_double(Formula, name: "foo", path: "blah", tap: CoreTap.instance) }
it "does not report event if BuildError is raised" do it "does not report event if BuildError is raised" do
allow_any_instance_of(Pathname).to receive(:directory?).and_return(false) allow_any_instance_of(Pathname).to receive(:directory?).and_return(false)