From f1ab720000ee6ead82c22aa781e7db2ce0860324 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Thu, 9 Mar 2023 21:54:37 +0000 Subject: [PATCH] rubocop: Drop "c1" and "c2" from `Naming/MethodParameterName` allowlist --- Library/.rubocop.yml | 2 -- Library/Homebrew/rubocops/components_order.rb | 10 +++++----- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index b7e0c8dd42..9963ea9953 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -191,8 +191,6 @@ Naming/MethodParameterName: [ "a", "b", - "c1", - "c2", "e", "f", "o", diff --git a/Library/Homebrew/rubocops/components_order.rb b/Library/Homebrew/rubocops/components_order.rb index 4661aed6fa..e7791563cd 100644 --- a/Library/Homebrew/rubocops/components_order.rb +++ b/Library/Homebrew/rubocops/components_order.rb @@ -214,13 +214,13 @@ module RuboCop end # Method to report and correct component precedence violations. - def component_problem(c1, c2) + def component_problem(component1, component2) return if tap_style_exception? :components_order_exceptions - problem "`#{format_component(c1)}` (line #{line_number(c1)}) " \ - "should be put before `#{format_component(c2)}` " \ - "(line #{line_number(c2)})" do |corrector| - reorder_components(corrector, c1, c2) + problem "`#{format_component(component1)}` (line #{line_number(component1)}) " \ + "should be put before `#{format_component(component2)}` " \ + "(line #{line_number(component2)})" do |corrector| + reorder_components(corrector, component1, component2) end end