admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Use add_attribute method instead of accessing attributes hash

Browse Source
This commit is contained in:
Jack Nagel 2014-12-02 21:14:53 -05:00
parent b9474dfc42
commit f0e01a0578
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Library/Homebrew/cmd/test-bot.rb
View File

@ -679,16 +679,18 @@ module Homebrew
if ARGV.include? "--junit"
xml_document = REXML::Document.new
xml_document << REXML::XMLDecl.new
testsuites = xml_document.add_element 'testsuites'
testsuites = xml_document.add_element "testsuites"
tests.each do |test|
testsuite = testsuites.add_element 'testsuite'
testsuite.attributes['name'] = "brew-test-bot.#{MacOS.cat}"
testsuite.attributes['tests'] = test.steps.count
testsuite = testsuites.add_element "testsuite"
testsuite.add_attribute "name", "brew-test-bot.#{MacOS.cat}"
testsuite.add_attribute "tests", test.steps.count
test.steps.each do |step|
testcase = testsuite.add_element 'testcase'
testcase.attributes['name'] = step.command_short
testcase.attributes['status'] = step.status
testcase.attributes['time'] = step.time
testcase = testsuite.add_element "testcase"
testcase.add_attribute "name", step.command_short
testcase.add_attribute "status", step.status
testcase.add_attribute "time", step.time
if step.has_output?
# Remove invalid XML CData characters from step output.