From 1502e5b89780629bd5fc9d4d0e49a621c3be02fa Mon Sep 17 00:00:00 2001 From: JCount Date: Fri, 21 Jul 2017 19:56:26 -0400 Subject: [PATCH 1/2] version: improve devel spec version parsing term this 'devel spec version style'; also improve dash version style parsing --- Library/Homebrew/version.rb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Library/Homebrew/version.rb b/Library/Homebrew/version.rb index ddeaa6feec..b03a4bc332 100644 --- a/Library/Homebrew/version.rb +++ b/Library/Homebrew/version.rb @@ -406,6 +406,14 @@ class Version m = /[-_](\d+\.\d+(?:\.\d+)?(?:-\d+)?)[-_.](?:i[36]86|x86|x64(?:[-_](?:32|64))?)$/.match(stem) return m.captures.first unless m.nil? + # devel spec + # e.g. https://registry.npmjs.org/@angular/cli/-/cli-1.3.0-beta.1.tgz + # e.g. https://github.com/dlang/dmd/archive/v2.074.0-beta1.tar.gz + # e.g. https://github.com/dlang/dmd/archive/v2.074.0-rc1.tar.gz + # e.g. https://github.com/premake/premake-core/releases/download/v5.0.0-alpha10/premake-5.0.0-alpha10-src.zip + m = /[-.vV]?((?:\d+\.)+\d+[-_.]?(?i:alpha|beta|pre|rc)\.?\d{,2})/.match(stem) + return m.captures.first unless m.nil? + # e.g. foobar4.5.1 m = /((?:\d+\.)*\d+)$/.match(stem) return m.captures.first unless m.nil? @@ -414,6 +422,15 @@ class Version m = /-((?:\d+\.)+\d+[abc]?)[-._](?:bin|dist|stable|src|sources?)$/.match(stem) return m.captures.first unless m.nil? + # dash version style + # e.g. http://www.antlr.org/download/antlr-3.4-complete.jar + # e.g. https://cdn.nuxeo.com/nuxeo-9.2/nuxeo-server-9.2-tomcat.zip + # e.g. https://search.maven.org/remotecontent?filepath=com/facebook/presto/presto-cli/0.181/presto-cli-0.181-executable.jar + # e.g. https://search.maven.org/remotecontent?filepath=org/fusesource/fuse-extra/fusemq-apollo-mqtt/1.3/fusemq-apollo-mqtt-1.3-uber.jar + # e.g. https://search.maven.org/remotecontent?filepath=org/apache/orc/orc-tools/1.2.3/orc-tools-1.2.3-uber.jar + m = /-((?:\d+\.)+\d+)-/.match(stem) + return m.captures.first unless m.nil? + # e.g. dash_0.5.5.1.orig.tar.gz (Debian style) m = /_((?:\d+\.)+\d+[abc]?)[.]orig$/.match(stem) return m.captures.first unless m.nil? From a5fff4547f460642728c88dbad76267f83afa170 Mon Sep 17 00:00:00 2001 From: JCount Date: Sat, 22 Jul 2017 19:21:38 -0400 Subject: [PATCH 2/2] verion_spec: add test coverage for devel spec version style also expand coverage for improved dash version style --- Library/Homebrew/test/version_spec.rb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/Library/Homebrew/test/version_spec.rb b/Library/Homebrew/test/version_spec.rb index deb91ed893..cee57e9352 100644 --- a/Library/Homebrew/test/version_spec.rb +++ b/Library/Homebrew/test/version_spec.rb @@ -453,6 +453,17 @@ describe Version do .to be_detected_from("https://example.com/dada-v2017-04-17.tar.gz") end + specify "devel spec version style" do + expect(Version.create("1.3.0-beta.1")) + .to be_detected_from("https://registry.npmjs.org/@angular/cli/-/cli-1.3.0-beta.1.tgz") + expect(Version.create("2.074.0-beta1")) + .to be_detected_from("https://github.com/dlang/dmd/archive/v2.074.0-beta1.tar.gz") + expect(Version.create("2.074.0-rc1")) + .to be_detected_from("https://github.com/dlang/dmd/archive/v2.074.0-rc1.tar.gz") + expect(Version.create("5.0.0-alpha10")) + .to be_detected_from("https://github.com/premake/premake-core/releases/download/v5.0.0-alpha10/premake-5.0.0-alpha10-src.zip") + end + specify "jenkins version style" do expect(Version.create("1.486")) .to be_detected_from("http://mirrors.jenkins-ci.org/war/1.486/jenkins.war") @@ -479,6 +490,12 @@ describe Version do specify "dash version style" do expect(Version.create("3.4")) .to be_detected_from("http://www.antlr.org/download/antlr-3.4-complete.jar") + expect(Version.create("9.2")) + .to be_detected_from("https://cdn.nuxeo.com/nuxeo-9.2/nuxeo-server-9.2-tomcat.zip") + expect(Version.create("0.181")) + .to be_detected_from("https://search.maven.org/remotecontent?filepath=com/facebook/presto/presto-cli/0.181/presto-cli-0.181-executable.jar") + expect(Version.create("1.2.3")) + .to be_detected_from("https://search.maven.org/remotecontent?filepath=org/apache/orc/orc-tools/1.2.3/orc-tools-1.2.3-uber.jar") end specify "apache version style" do