From a21b2dc833066aba31f1748b6c053c754e391a17 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Thu, 21 Dec 2023 10:00:46 +0000 Subject: [PATCH] rubocops/cask/on_system_conditionals: allow blocks. Without this, there's an infinite loop on `brew style --fix` if you have a `if Hardware::CPU.arm?` in a `postflight` block where it will change back and forward between `if` and `on_os` syntax forever. --- Library/Homebrew/rubocops/cask/on_system_conditionals.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/rubocops/cask/on_system_conditionals.rb b/Library/Homebrew/rubocops/cask/on_system_conditionals.rb index 0887c8d54e..a5b791e81d 100644 --- a/Library/Homebrew/rubocops/cask/on_system_conditionals.rb +++ b/Library/Homebrew/rubocops/cask/on_system_conditionals.rb @@ -40,7 +40,7 @@ module RuboCop audit_on_system_blocks(stanza.stanza_node, stanza.stanza_name) end - audit_arch_conditionals(cask_body) + audit_arch_conditionals(cask_body, allowed_blocks: FLIGHT_STANZA_NAMES) audit_macos_version_conditionals(cask_body, recommend_on_system: false) simplify_sha256_stanzas end