diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb index 9728aba9b9..0dc835ff1d 100644 --- a/Library/Homebrew/cmd/install.rb +++ b/Library/Homebrew/cmd/install.rb @@ -289,7 +289,7 @@ module Homebrew Cleanup.install_formula_clean!(f) end - Upgrade.check_installed_dependents(args: args) + Upgrade.check_installed_dependents(installed_formulae, args: args) Homebrew.messages.display_messages(display_times: args.display_times?) rescue FormulaUnreadableError, FormulaClassUnavailableError, diff --git a/Library/Homebrew/cmd/reinstall.rb b/Library/Homebrew/cmd/reinstall.rb index ab69edd5d3..7c58fb9c2b 100644 --- a/Library/Homebrew/cmd/reinstall.rb +++ b/Library/Homebrew/cmd/reinstall.rb @@ -102,7 +102,7 @@ module Homebrew Cleanup.install_formula_clean!(f) end - Upgrade.check_installed_dependents(args: args) + Upgrade.check_installed_dependents(formulae, args: args) if casks.any? Cask::Cmd::Reinstall.reinstall_casks( diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb index 6cb7574b66..ae0f3ba280 100644 --- a/Library/Homebrew/cmd/upgrade.rb +++ b/Library/Homebrew/cmd/upgrade.rb @@ -172,7 +172,7 @@ module Homebrew Upgrade.upgrade_formulae(formulae_to_install, args: args) - Upgrade.check_installed_dependents(args: args) + Upgrade.check_installed_dependents(formulae_to_install, args: args) Homebrew.messages.display_messages(display_times: args.display_times?) end diff --git a/Library/Homebrew/upgrade.rb b/Library/Homebrew/upgrade.rb index 15602d126a..9db3af360f 100644 --- a/Library/Homebrew/upgrade.rb +++ b/Library/Homebrew/upgrade.rb @@ -134,10 +134,10 @@ module Homebrew end end - def check_installed_dependents(args:) + def check_installed_dependents(formulae, args:) return if Homebrew::EnvConfig.no_installed_dependents_check? - installed_formulae = FormulaInstaller.installed.to_a + installed_formulae = args.dry_run? ? formulae : FormulaInstaller.installed.to_a return if installed_formulae.empty? already_broken_dependents = check_broken_dependents(installed_formulae)