admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #4743 from maxim-belkin/mac-libs

Browse Source 
formula_cellar_checks: .dylib and .framework are macOS-specific
This commit is contained in:
Shaun Jackman 2018-08-23 08:31:38 -07:00 committed by GitHub
commit ef149f2e2c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
View File

@ -94,4 +94,9 @@ module FormulaCellarChecks
problem_if_output(check_python_framework_links(formula.lib)) problem_if_output(check_python_framework_links(formula.lib))
check_linkage check_linkage
end end
def valid_library_extension?(filename)
macos_lib_extensions = %w[.dylib .framework]
generic_valid_library_extension?(filename) || macos_lib_extensions.include?(filename.extname)
end
end end

2
Library/Homebrew/formula_cellar_checks.rb
View File

@ -56,7 +56,7 @@ module FormulaCellarChecks
EOS EOS
end end
VALID_LIBRARY_EXTENSIONS = %w[.a .dylib .framework .jnilib .la .o .so .jar .prl .pm .sh].freeze VALID_LIBRARY_EXTENSIONS = %w[.a .jnilib .la .o .so .jar .prl .pm .sh].freeze
def valid_library_extension?(filename) def valid_library_extension?(filename)
VALID_LIBRARY_EXTENSIONS.include? filename.extname VALID_LIBRARY_EXTENSIONS.include? filename.extname