From eec60c4086122b915ff4023b5f97a99bbaa1b97d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?fn=20=E2=8C=83=20=E2=8C=A5?= <70830482+FnControlOption@users.noreply.github.com> Date: Thu, 9 Sep 2021 10:54:18 -0700 Subject: [PATCH] install, upgrade: don't print message if formula already installed --- Library/Homebrew/install.rb | 4 ++-- Library/Homebrew/upgrade.rb | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/install.rb b/Library/Homebrew/install.rb index b68aa6bec9..52e630ab00 100644 --- a/Library/Homebrew/install.rb +++ b/Library/Homebrew/install.rb @@ -289,6 +289,8 @@ module Homebrew def install_formula(formula_installer, only_deps: false) f = formula_installer.formula + formula_installer.prelude + f.print_tap_action if f.linked_keg.directory? @@ -316,8 +318,6 @@ module Homebrew end end - formula_installer.prelude - kegs.each(&:unlink) if kegs.present? formula_installer.install diff --git a/Library/Homebrew/upgrade.rb b/Library/Homebrew/upgrade.rb index 62a38a9dc0..b90bdfb6dc 100644 --- a/Library/Homebrew/upgrade.rb +++ b/Library/Homebrew/upgrade.rb @@ -165,12 +165,12 @@ module Homebrew if dry_run print_dry_run_dependencies(formula, formula_installer.compute_dependencies) return - else - print_upgrade_message(formula, formula_installer.options) end formula_installer.prelude + print_upgrade_message(formula, formula_installer.options) + # first we unlink the currently active keg for this formula otherwise it is # possible for the existing build to interfere with the build we are about to # do! Seriously, it happens!