admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

test/deprecate_disable_spec: increase test coverage

Browse Source
This commit is contained in:
Michael Cho 2024-12-20 14:19:35 -05:00
parent 21f35368eb
commit eebcd60bd9
No known key found for this signature in database
GPG Key ID: 55E85E28A7CD1E85
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Library/Homebrew/test/deprecate_disable_spec.rb
View File

@ -3,14 +3,24 @@
require "deprecate_disable" require "deprecate_disable"
RSpec.describe DeprecateDisable do RSpec.describe DeprecateDisable do
let(:deprecate_date) { Date.parse("2020-01-01") }
let(:disable_date) { deprecate_date >> DeprecateDisable::REMOVE_DISABLED_TIME_WINDOW }
let(:deprecated_formula) do let(:deprecated_formula) do
instance_double(Formula, deprecated?: true, disabled?: false, deprecation_reason: :does_not_build, instance_double(Formula, deprecated?: true, disabled?: false, deprecation_reason: :does_not_build,
deprecation_replacement: nil, deprecation_date: nil, disable_date: nil) deprecation_replacement: nil, deprecation_date: nil, disable_date: nil)
end end
let(:deprecated_formula_with_date) do
instance_double(Formula, deprecated?: true, disabled?: false, deprecation_reason: :does_not_build,
deprecation_replacement: nil, deprecation_date: deprecate_date, disable_date: nil)
end
let(:disabled_formula) do let(:disabled_formula) do
instance_double(Formula, deprecated?: false, disabled?: true, disable_reason: "is broken", instance_double(Formula, deprecated?: false, disabled?: true, disable_reason: "is broken",
disable_replacement: nil, deprecation_date: nil, disable_date: nil) disable_replacement: nil, deprecation_date: nil, disable_date: nil)
end end
let(:disabled_formula_with_date) do
instance_double(Formula, deprecated?: false, disabled?: true, disable_reason: :does_not_build,
disable_replacement: nil, deprecation_date: nil, disable_date: disable_date)
end
let(:deprecated_cask) do let(:deprecated_cask) do
instance_double(Cask::Cask, deprecated?: true, disabled?: false, deprecation_reason: :discontinued, instance_double(Cask::Cask, deprecated?: true, disabled?: false, deprecation_reason: :discontinued,
deprecation_replacement: nil, deprecation_date: nil, disable_date: nil) deprecation_replacement: nil, deprecation_date: nil, disable_date: nil)
@ -39,7 +49,9 @@ RSpec.describe DeprecateDisable do
before do before do
formulae = [ formulae = [
deprecated_formula, deprecated_formula,
deprecated_formula_with_date,
disabled_formula, disabled_formula,
disabled_formula_with_date,
deprecated_formula_with_replacement, deprecated_formula_with_replacement,
disabled_formula_with_replacement, disabled_formula_with_replacement,
] ]
@ -86,11 +98,22 @@ RSpec.describe DeprecateDisable do
.to eq "deprecated because it does not build!" .to eq "deprecated because it does not build!"
end end
it "returns a deprecation message with disable date" do
allow(Date).to receive(:today).and_return(deprecate_date + 1)
expect(described_class.message(deprecated_formula_with_date))
.to eq "deprecated because it does not build! It will be disabled on #{disable_date}."
end
it "returns a disable message with a custom reason" do it "returns a disable message with a custom reason" do
expect(described_class.message(disabled_formula)) expect(described_class.message(disabled_formula))
.to eq "disabled because it is broken!" .to eq "disabled because it is broken!"
end end
it "returns a disable message with disable date" do
expect(described_class.message(disabled_formula_with_date))
.to eq "disabled because it does not build! It was disabled on #{disable_date}."
end
it "returns a deprecation message with a preset cask reason" do it "returns a deprecation message with a preset cask reason" do
expect(described_class.message(deprecated_cask)) expect(described_class.message(deprecated_cask))
.to eq "deprecated because it is discontinued upstream!" .to eq "deprecated because it is discontinued upstream!"