admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove $PATH from --config and build dumps.

Browse Source 
While it is useful to be able to see the user's path in bug reports, it is
perhaps slightly too intrusive to post this without the user's permission.

A path can have usernames or other project sensitive information, and several
Homebrew users were editing their bug reports to omit this information.

`brew doctor` will still report on the path issues that we typically care
about, so dropping automatic posting of PATH.
This commit is contained in:
Adam Vandenberg 2010-07-02 09:34:40 -07:00
parent 8806d91662
commit ecb5ce103e
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/utils.rb
View File

@ -218,7 +218,7 @@ end
def dump_build_env env def dump_build_env env
puts "\"--use-llvm\" was specified" if ARGV.include? '--use-llvm' puts "\"--use-llvm\" was specified" if ARGV.include? '--use-llvm'
%w[CC CXX LD CFLAGS CXXFLAGS CPPFLAGS LDFLAGS MACOSX_DEPLOYMENT_TARGET MAKEFLAGS PATH PKG_CONFIG_PATH HOMEBREW_USE_LLVM].each do |k| %w[CC CXX LD CFLAGS CXXFLAGS CPPFLAGS LDFLAGS MACOSX_DEPLOYMENT_TARGET MAKEFLAGS PKG_CONFIG_PATH HOMEBREW_USE_LLVM].each do |k|
value = env[k] value = env[k]
puts "#{k}: #{value}" if value puts "#{k}: #{value}" if value
end end

1
bin/brew
View File

@ -65,7 +65,6 @@ GCC-4.2: #{gcc_42 ? "build #{gcc_42}" : "N/A"} (#{RECOMMENDED_GCC_42} or newer r
LLVM: #{llvm ? "build #{llvm}" : "N/A" } #{llvm ? "(#{RECOMMENDED_LLVM} or newer recommended)" : "" } LLVM: #{llvm ? "build #{llvm}" : "N/A" } #{llvm ? "(#{RECOMMENDED_LLVM} or newer recommended)" : "" }
MacPorts or Fink? #{macports_or_fink_installed?} MacPorts or Fink? #{macports_or_fink_installed?}
X11 installed? #{x11_installed?} X11 installed? #{x11_installed?}
PATH: #{ENV['PATH']}
EOS EOS
end end