From eb16d746d798b1b8cecc1de97b54d85598a2e453 Mon Sep 17 00:00:00 2001
From: Jack Nagel <jacknagel@gmail.com>
Date: Sat, 13 Apr 2013 16:36:30 -0500
Subject: [PATCH] Clean up checksum verification tests

---
 .../test/test_checksum_verification.rb        | 49 ++++++++++++++++++
 Library/Homebrew/test/test_checksums.rb       | 50 -------------------
 2 files changed, 49 insertions(+), 50 deletions(-)
 create mode 100644 Library/Homebrew/test/test_checksum_verification.rb
 delete mode 100644 Library/Homebrew/test/test_checksums.rb

diff --git a/Library/Homebrew/test/test_checksum_verification.rb b/Library/Homebrew/test/test_checksum_verification.rb
new file mode 100644
index 0000000000..a97cd985a0
--- /dev/null
+++ b/Library/Homebrew/test/test_checksum_verification.rb
@@ -0,0 +1,49 @@
+require 'testing_env'
+require 'test/testball'
+
+class ChecksumTests < Test::Unit::TestCase
+  def assert_checksum_good
+    assert_nothing_raised { shutup { @_f.brew {} } }
+  end
+
+  def assert_checksum_bad
+    assert_raises(ChecksumMismatchError) { shutup { @_f.brew {} } }
+  end
+
+  def formula(&block)
+    @_f = TestBall.new
+    @_f.stable.instance_eval(&block)
+  end
+
+  def test_good_sha1
+    formula do
+      sha1 '482e737739d946b7c8cbaf127d9ee9c148b999f5'
+    end
+
+    assert_checksum_good
+  end
+
+  def test_bad_sha1
+    formula do
+      sha1 '7ea8a98acb8f918df723c2ae73fe67d5664bfd7e'
+    end
+
+    assert_checksum_bad
+  end
+
+  def test_good_sha256
+    formula do
+      sha256 '1dfb13ce0f6143fe675b525fc9e168adb2215c5d5965c9f57306bb993170914f'
+    end
+
+    assert_checksum_good
+  end
+
+  def test_bad_sha256
+    formula do
+      sha256 'dcbf5f44743b74add648c7e35e414076632fa3b24463d68d1f6afc5be77024f8'
+    end
+
+    assert_checksum_bad
+  end
+end
diff --git a/Library/Homebrew/test/test_checksums.rb b/Library/Homebrew/test/test_checksums.rb
deleted file mode 100644
index b5549e8017..0000000000
--- a/Library/Homebrew/test/test_checksums.rb
+++ /dev/null
@@ -1,50 +0,0 @@
-require 'testing_env'
-require 'test/testball'
-
-class ChecksumTests < Test::Unit::TestCase
-  def good_checksum f
-    assert_nothing_raised { shutup { f.brew {} } }
-  end
-
-  def bad_checksum f
-    assert_raises ChecksumMismatchError do
-      shutup { f.brew {} }
-    end
-  end
-
-  def test_sha1
-    valid_sha1 = TestBall.new
-    valid_sha1.stable.instance_eval do
-      sha1 '482e737739d946b7c8cbaf127d9ee9c148b999f5'
-    end
-
-    good_checksum valid_sha1
-  end
-
-  def test_badsha1
-    invalid_sha1 = TestBall.new
-    invalid_sha1.stable.instance_eval do
-      sha1 '7ea8a98acb8f918df723c2ae73fe67d5664bfd7e'
-    end
-
-    bad_checksum invalid_sha1
-  end
-
-  def test_sha256
-    valid_sha256 = TestBall.new
-    valid_sha256.stable.instance_eval do
-      sha256 '1dfb13ce0f6143fe675b525fc9e168adb2215c5d5965c9f57306bb993170914f'
-    end
-
-    good_checksum valid_sha256
-  end
-
-  def test_badsha256
-    invalid_sha256 = TestBall.new
-    invalid_sha256.stable.instance_eval do
-      sha256 'dcbf5f44743b74add648c7e35e414076632fa3b24463d68d1f6afc5be77024f8'
-    end
-
-    bad_checksum invalid_sha256
-  end
-end