admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: check system dupe deps on new formulae.

Browse Source 
Provide a gentle nudge to users to check if these dependencies are
definitely required.
This commit is contained in:
Mike McQuaid 2017-03-19 20:45:21 +02:00
parent 09a926f449
commit eadbd95d2c
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/dev-cmd/audit.rb
View File

@ -472,6 +472,12 @@ class FormulaAuditor
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end end
if @new_formula && dep_f.keg_only_reason &&
!["openssl", "apr", "apr-util"].include?(dep.name) &&
[:provided_by_macos, :provided_by_osx].include?(dep_f.keg_only_reason.reason)
problem "Dependency '#{dep.name}' may be unnecessary as it is provided by macOS; try to build this formula without it."
end
dep.options.reject do |opt| dep.options.reject do |opt|
next true if dep_f.option_defined?(opt) next true if dep_f.option_defined?(opt)
dep_f.requirements.detect do |r| dep_f.requirements.detect do |r|

2
Library/Homebrew/formula_support.rb
View File

@ -4,6 +4,8 @@ FormulaConflict = Struct.new(:name, :reason)
# Used to annotate formulae that duplicate macOS provided software # Used to annotate formulae that duplicate macOS provided software
# or cause conflicts when linked in. # or cause conflicts when linked in.
class KegOnlyReason class KegOnlyReason
attr_reader :reason
def initialize(reason, explanation) def initialize(reason, explanation)
@reason = reason @reason = reason
@explanation = explanation @explanation = explanation