admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

update command comparison to *commands vararg

Browse Source
This commit is contained in:
Max Eisner 2022-08-18 20:55:51 +02:00
parent 3db65e7ee5
commit ea4fb0fe09
No known key found for this signature in database
GPG Key ID: 4BF122C22879F0C8
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/rubocops/lines.rb
View File

@ -521,9 +521,12 @@ module RuboCop
return if offenses.blank?
T.must(offenses[0...-1]).each_with_index do |node, i|
# executable and subcmd have to be the same to be combined
if node.arguments.first != offenses[i + 1].arguments.first ||
node.arguments.second != offenses[i + 1].arguments.second
# commands have to be the same to be combined
# send_type? matches `bin/"foo"`, str_type? matches remaining command parts,
# the rest are kwargs we need to filter out
method_commands = node.arguments.filter { |arg| arg.send_type? || arg.str_type? }
next_method_commands = offenses[i + 1].arguments.filter { |arg| arg.send_type? || arg.str_type? }
unless method_commands == next_method_commands
shells.delete_at(i)
next
end