From e9158ca6dc99e3bb7ae475bee98153e78cafa2b0 Mon Sep 17 00:00:00 2001 From: Matt Di Pasquale Date: Sat, 19 Jan 2013 19:45:18 -0500 Subject: [PATCH] brew upgrade: improve exit codes. exit 1 if formulae given but none outdated Closes Homebrew/homebrew#17199. Signed-off-by: Mike McQuaid --- Library/Homebrew/cmd/upgrade.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb index c3a924ec51..6d477d6a8e 100644 --- a/Library/Homebrew/cmd/upgrade.rb +++ b/Library/Homebrew/cmd/upgrade.rb @@ -16,11 +16,11 @@ module Homebrew extend self Homebrew.perform_preinstall_checks - outdated = if ARGV.named.empty? + if ARGV.named.empty? require 'cmd/outdated' - Homebrew.outdated_brews + outdated = Homebrew.outdated_brews else - ARGV.formulae.select do |f| + outdated = ARGV.formulae.select do |f| if f.installed? onoe "#{f}-#{f.installed_version} already installed" elsif not f.rack.exist? or f.rack.children.empty? @@ -29,6 +29,7 @@ module Homebrew extend self true end end + exit 1 if outdated.empty? end # Expand the outdated list to include outdated dependencies then sort and