admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

brew-audit - catch more interpolation style issues

Browse Source
This commit is contained in:
Adam Vandenberg 2010-09-07 14:34:39 -07:00
parent 2bb9fa1b22
commit e9043abc57
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Contributions/examples/brew-audit.rb
View File

@ -19,7 +19,7 @@ def audit_formula_text text
problems << " * Remove 'use_mirror' from url." problems << " * Remove 'use_mirror' from url."
end end
# 2 (or more, if in an if block) spaces before depends_on, please # 2 (or more in an if block) spaces before depends_on, please
if text =~ /^\ ?depends_on/ if text =~ /^\ ?depends_on/
problems << " * Check indentation of 'depends_on'." problems << " * Check indentation of 'depends_on'."
end end
@ -29,6 +29,11 @@ def audit_formula_text text
problems << " * Don't need 'FileUtils.' before #{$1}." problems << " * Don't need 'FileUtils.' before #{$1}."
end end
# Check for string interpolation of single values.
if text =~ /(system|inreplace|gsub!|change_make_var!) .* ['"]#\{(\w+)\}['"]/
problems << " * Don't need to interpolate \"#{$2}\" with #{$1}"
end
# Check for string concatenation; prefer interpolation # Check for string concatenation; prefer interpolation
if text =~ /(#\{\w+\s*\+\s*['"][^}]+\})/ if text =~ /(#\{\w+\s*\+\s*['"][^}]+\})/
problems << " * Try not to concatenate paths in string interpolation:\n #{$1}" problems << " * Try not to concatenate paths in string interpolation:\n #{$1}"