From e8c71aeb8cc191ede9e224d1fd6f6c152eba7e38 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 12 Feb 2021 11:25:44 +0000 Subject: [PATCH] rubocops/lines: check for `if ENV["CI"]` usage. Suggested in: https://github.com/Homebrew/homebrew-core/pull/70675#issuecomment-775092539 --- Library/Homebrew/rubocops/lines.rb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index fba426055f..a7c7b5aa54 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -546,6 +546,15 @@ module RuboCop problem "`depends_on` can take requirement classes instead of instances" end + find_instance_method_call(body_node, "ENV", :[]) do |method| + next unless modifier?(method.parent) + + param = parameters(method).first + next unless node_equals?(param, "CI") + + problem 'Don\'t use ENV["CI"] for Homebrew CI checks.' + end + find_instance_method_call(body_node, "Dir", :[]) do |method| next unless parameters(method).size == 1