admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Skip standard compilers check for unknown Xcode

Browse Source 
Rescuing false on the StandardCompilers map meant that the doctor
check assumed that the compilers were incorrect, not merely
unknown.

Instead, skip the check and return nil for unknown Xcode; nil
should be interpreted as "dunno", instead of "true" or "false",
and the doctor check no longer prints on nil.
This commit is contained in:
Misty De Meo 2012-09-14 16:58:38 -05:00
parent 50efa98638
commit e8c372a315
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/cmd/doctor.rb
View File

@ -259,7 +259,8 @@ end
def check_standard_compilers
return if check_for_latest_xcode # only check if Xcode is up to date
if !MacOS.compilers_standard? then <<-EOS.undent
compiler_status = MacOS.compilers_standard?
if not compiler_status and not compiler_status.nil? then <<-EOS.undent
Your compilers are different from the standard versions for your Xcode.
If you have Xcode 4.3 or newer, you should install the Command Line Tools for
Xcode from within Xcode's Download preferences.

3
Library/Homebrew/macos.rb
View File

@ -204,9 +204,10 @@ module MacOS extend self
Thanks!
EOS
return
end
StandardCompilers[xcode].all? { |method, build| MacOS.send(method) == build } rescue false
StandardCompilers[xcode].all? { |method, build| MacOS.send(method) == build }
end
def app_with_bundle_id id