admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: merge the template comments checks

Browse Source 
Closes Homebrew/homebrew#45263.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
This commit is contained in:
Baptiste Fontaine 2015-10-23 10:33:34 +02:00
parent 774a508d1a
commit e7ef3e36e2
1 changed files with 13 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
Library/Homebrew/cmd/audit.rb
View File

@ -609,29 +609,19 @@ class FormulaAuditor
end
# Comments from default template
if line =~ /# PLEASE REMOVE/
problem "Please remove default template comments"
end
if line =~ /# Documentation:/
problem "Please remove default template comments"
end
if line =~ /# if this fails, try separate make\/make install steps/
problem "Please remove default template comments"
end
if line =~ /# The URL of the archive/
problem "Please remove default template comments"
end
if line =~ /## Naming --/
problem "Please remove default template comments"
end
if line =~ /# if your formula requires any X11\/XQuartz components/
problem "Please remove default template comments"
end
if line =~ /# if your formula fails when building in parallel/
problem "Please remove default template comments"
end
if line =~ /# Remove unrecognized options if warned by configure/
problem "Please remove default template comments"
[
"# PLEASE REMOVE",
"# Documentation:",
"# if this fails, try separate make/make install steps",
"# The URL of the archive",
"## Naming --",
"# if your formula requires any X11/XQuartz components",
"# if your formula fails when building in parallel",
"# Remove unrecognized options if warned by configure",
].each do |comment|
if line.include? comment
problem "Please remove default template comments"
end
end
# FileUtils is included in Formula