admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #15284 from carlocab/rm-issue-comment

Browse Source 
formula_auditor: remove issue comment audit
This commit is contained in:
Carlo Cabrera 2023-04-22 02:10:59 +08:00 committed by GitHub
commit e7ac13b44a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Library/Homebrew/formula_auditor.rb
View File

@ -826,28 +826,6 @@ module Homebrew
end end
end end
def audit_github_issue_comment
return unless @online
matches = text.to_s.scan(%r{https://github.com/([-\w_]*)/([-\w_]*)/(pull|issues)/([0-9]*)})
return unless matches
matches.each do |match|
owner, repo, type, id = match
# Do not trigger for self references
next if "#{owner}/#{repo}" == formula.tap.remote_repo || owner == "Homebrew"
issue = GitHub::API.open_rest("https://api.github.com/repos/#{owner}/#{repo}/issues/#{id}")
next if issue.blank?
next if issue["state"] == "open"
next if issue.dig("pull_request", "merged_at").present?
issue_url = "https://github.com/#{owner}/#{repo}/#{type}/#{id}"
problem "Formula refers to a GitHub issue or pull request that is closed: #{issue_url}"
end
end
def audit_reverse_migration def audit_reverse_migration
# Only enforce for new formula being re-added to core # Only enforce for new formula being re-added to core
return unless @strict return unless @strict