admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

livecheck: Fix debug strategy info printing

Browse Source 
The `ExtractPlist` strategy doesn't return certain values (e.g.,
`:url`), so it's necessary to also ensure these values are present
before printing related debug info. Without these changes, we end up
printing info for a blank value (e.g., "URL (strategy):").
This commit is contained in:
Sam Ford 2021-11-16 12:39:27 -05:00
parent 9e8900fb6e
commit e73524b093
No known key found for this signature in database
GPG Key ID: 95209E46C7FFDEFE
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/livecheck/livecheck.rb
View File

@ -658,9 +658,13 @@ module Homebrew
end end
if debug if debug
puts "URL (strategy): #{strategy_data[:url]}" if strategy_data[:url] != url if strategy_data[:url].present? && strategy_data[:url] != url
puts "URL (final): #{strategy_data[:final_url]}" if strategy_data[:final_url] puts "URL (strategy): #{strategy_data[:url]}"
puts "Regex (strategy): #{strategy_data[:regex].inspect}" if strategy_data[:regex] != livecheck_regex end
puts "URL (final): #{strategy_data[:final_url]}" if strategy_data[:final_url].present?
if strategy_data[:regex].present? && strategy_data[:regex] != livecheck_regex
puts "Regex (strategy): #{strategy_data[:regex].inspect}"
end
puts "Cached?: Yes" if strategy_data[:cached] == true puts "Cached?: Yes" if strategy_data[:cached] == true
end end