admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_installer: improve quiet output.

Browse Source 
Quieten a few warnings, messages and caveats if we're passing `--quiet`
to `brew install`.

This also quiets an incorrect "Fetching" message that was being shown
when installing from a local bottle.
This commit is contained in:
Mike McQuaid 2025-01-23 14:06:39 +00:00
parent 0a422daf68
commit e6b8ed8940
No known key found for this signature in database
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
Library/Homebrew/formula_installer.rb
View File

@ -440,7 +440,8 @@ class FormulaInstaller
# Warn if a more recent version of this formula is available in the tap.
begin
if formula.pkg_version < (v = Formulary.factory(formula.full_name, force_bottle: force_bottle?).pkg_version)
if !quiet? &&
formula.pkg_version < (v = Formulary.factory(formula.full_name, force_bottle: force_bottle?).pkg_version)
opoo "#{formula.full_name} #{v} is available and more recent than version #{formula.pkg_version}."
end
rescue FormulaUnavailableError
@ -847,6 +848,7 @@ on_request: installed_on_request?, options:)
audit_installed if Homebrew::EnvConfig.developer?
return if !installed_on_request? || installed_as_dependency?
return if quiet?
caveats = Caveats.new(formula)
@ -873,13 +875,15 @@ on_request: installed_on_request?, options:)
Homebrew::Install.global_post_install
if build_bottle? || skip_post_install?
if build_bottle?
ohai "Not running 'post_install' as we're building a bottle"
elsif skip_post_install?
ohai "Skipping 'post_install' on request"
unless quiet?
if build_bottle?
ohai "Not running 'post_install' as we're building a bottle"
elsif skip_post_install?
ohai "Skipping 'post_install' on request"
end
puts "You can run it manually using:"
puts " brew postinstall #{formula.full_name}"
end
puts "You can run it manually using:"
puts " brew postinstall #{formula.full_name}"
else
formula.install_etc_var
post_install if formula.post_install_defined?
@ -1321,6 +1325,7 @@ on_request: installed_on_request?, options:)
fetch_dependencies
return if only_deps?
return if formula.local_bottle_path.present?
oh1 "Fetching #{Formatter.identifier(formula.full_name)}".strip
@ -1347,8 +1352,7 @@ on_request: installed_on_request?, options:)
if check_attestation &&
Homebrew::Attestation.enabled? &&
formula.tap&.core_tap? &&
formula.name != "gh" &&
formula.local_bottle_path.blank?
formula.name != "gh"
ohai "Verifying attestation for #{formula.name}"
begin
Homebrew::Attestation.check_core_attestation T.cast(downloadable_object, Bottle)