admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Convert Artifact::Pkg test to spec.

Browse Source
This commit is contained in:
Markus Reiter 2017-02-08 14:37:40 +01:00
parent 3db8cdf861
commit e5e8f545b7
2 changed files with 71 additions and 64 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

71
Library/Homebrew/cask/spec/cask/artifact/pkg_spec.rb Normal file
View File

@ -0,0 +1,71 @@
require "spec_helper"
describe Hbc::Artifact::Pkg do
let(:cask) { Hbc::CaskLoader.load_from_file(TEST_FIXTURE_DIR/"cask/Casks/with-installable.rb") }
let(:fake_system_command) { class_double(Hbc::SystemCommand) }
before(:each) do
shutup do
InstallHelper.install_without_artifacts(cask)
end
end
describe "install_phase" do
it "runs the system installer on the specified pkgs" do
pkg = Hbc::Artifact::Pkg.new(cask, command: fake_system_command)
expect(fake_system_command).to receive(:run!).with(
"/usr/sbin/installer",
args: ["-pkg", cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/"],
sudo: true,
print_stdout: true
)
shutup do
pkg.install_phase
end
end
end
describe "choices" do
let(:cask) { Hbc::CaskLoader.load_from_file(TEST_FIXTURE_DIR/"cask/Casks/with-choices.rb") }
it "passes the choice changes xml to the system installer" do
pkg = Hbc::Artifact::Pkg.new(cask, command: fake_system_command)
file = double(path: Pathname.new("/tmp/choices.xml"))
expect(file).to receive(:write).with(<<-EOS.undent)
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<array>
\t<dict>
\t\t<key>attributeSetting</key>
\t\t<integer>1</integer>
\t\t<key>choiceAttribute</key>
\t\t<string>selected</string>
\t\t<key>choiceIdentifier</key>
\t\t<string>choice1</string>
\t</dict>
</array>
</plist>
EOS
expect(file).to receive(:close)
expect(file).to receive(:unlink)
expect(Tempfile).to receive(:open).and_yield(file)
expect(fake_system_command).to receive(:run!).with(
"/usr/sbin/installer",
args: ["-pkg", cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/", "-applyChoiceChangesXML", cask.staged_path.join("/tmp/choices.xml")],
sudo: true,
print_stdout: true
)
shutup do
pkg.install_phase
end
end
end
end

64
Library/Homebrew/cask/test/cask/artifact/pkg_test.rb
View File

@ -1,64 +0,0 @@
require "test_helper"
describe Hbc::Artifact::Pkg do
before do
@cask = Hbc::CaskLoader.load_from_file(TEST_FIXTURE_DIR/"cask/Casks/with-installable.rb")
shutup do
TestHelper.install_without_artifacts(@cask)
end
end
describe "install_phase" do
it "runs the system installer on the specified pkgs" do
pkg = Hbc::Artifact::Pkg.new(@cask,
command: Hbc::FakeSystemCommand)
Hbc::FakeSystemCommand.expects_command(["/usr/bin/sudo", "-E", "--", "/usr/sbin/installer", "-pkg", @cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/"])
shutup do
pkg.install_phase
end
end
end
describe "choices" do
before do
@cask = Hbc::CaskLoader.load_from_file(TEST_FIXTURE_DIR/"cask/Casks/with-choices.rb")
shutup do
TestHelper.install_without_artifacts(@cask)
end
end
it "passes the choice changes xml to the system installer" do
pkg = Hbc::Artifact::Pkg.new(@cask, command: Hbc::FakeSystemCommand)
file = mock
file.expects(:write).with <<-EOS.undent
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<array>
\t<dict>
\t\t<key>attributeSetting</key>
\t\t<integer>1</integer>
\t\t<key>choiceAttribute</key>
\t\t<string>selected</string>
\t\t<key>choiceIdentifier</key>
\t\t<string>choice1</string>
\t</dict>
</array>
</plist>
EOS
file.stubs path: Pathname.new("/tmp/choices.xml")
file.expects(:close)
file.expects(:unlink)
Tempfile.expects(:open).yields file
Hbc::FakeSystemCommand.expects_command(["/usr/bin/sudo", "-E", "--", "/usr/sbin/installer", "-pkg", @cask.staged_path.join("MyFancyPkg", "Fancy.pkg"), "-target", "/", "-applyChoiceChangesXML", @cask.staged_path.join("/tmp/choices.xml")])
shutup do
pkg.install_phase
end
end
end
end