admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocop: Drop "p" from Naming/MethodParameterName allowlist

Browse Source 
- It's used to refer to a patch, so use the long name.
This commit is contained in:
Issy Long 2023-03-08 00:15:17 +00:00
parent 0cd616bc66
commit e273c25be0
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/.rubocop.yml
View File

@ -199,7 +199,6 @@ Naming/MethodParameterName:
"f", "f",
"ff", "ff",
"o", "o",
"p",
"pr", "pr",
] ]

4
Library/Homebrew/cmd/fetch.rb
View File

@ -152,8 +152,8 @@ module Homebrew
opoo "Cask reports different sha256: #{e.expected}" opoo "Cask reports different sha256: #{e.expected}"
end end
def self.fetch_patch(p, args:) def self.fetch_patch(patch, args:)
fetch_fetchable p, args: args fetch_fetchable patch, args: args
rescue ChecksumMismatchError => e rescue ChecksumMismatchError => e
opoo "Patch reports different sha256: #{e.expected}" opoo "Patch reports different sha256: #{e.expected}"
Homebrew.failed = true Homebrew.failed = true