Don't check Subversion HTTPS pre-Sierra.

The system Subversion doesn't handle new certificate authorities (e.g.
Let's Encrypt) well enough for this check to be useful.
This commit is contained in:
Mike McQuaid 2017-03-05 11:42:59 +01:00
parent 6d42e2a527
commit e26cf3a83f
3 changed files with 13 additions and 3 deletions

View File

@ -680,8 +680,6 @@ class FormulaAuditor
return unless @online return unless @online
# The system Curl is too old and unreliable with HTTPS homepages on
# Yosemite and below.
return unless DevelopmentTools.curl_handles_most_https_homepages? return unless DevelopmentTools.curl_handles_most_https_homepages?
if http_content_problem = FormulaAuditor.check_http_content(homepage, if http_content_problem = FormulaAuditor.check_http_content(homepage,
user_agents: [:browser, :default]) user_agents: [:browser, :default])
@ -1571,6 +1569,7 @@ class ResourceAuditor
problem "The URL #{url} is not a valid git URL" problem "The URL #{url} is not a valid git URL"
end end
elsif strategy <= SubversionDownloadStrategy elsif strategy <= SubversionDownloadStrategy
next unless DevelopmentTools.subversion_handles_most_https_certificates?
unless Utils.svn_remote_exists url unless Utils.svn_remote_exists url
problem "The URL #{url} is not a valid svn URL" problem "The URL #{url} is not a valid svn URL"
end end

View File

@ -117,6 +117,10 @@ class DevelopmentTools
def curl_handles_most_https_homepages? def curl_handles_most_https_homepages?
true true
end end
def subversion_handles_most_https_certificates?
true
end
end end
end end

View File

@ -78,8 +78,15 @@ class DevelopmentTools
end end
def curl_handles_most_https_homepages? def curl_handles_most_https_homepages?
# The system Curl is too old for some modern HTTPS homepages on Yosemite. # The system Curl is too old for some modern HTTPS homepages on
# older macOS versions.
MacOS.version >= :el_capitan MacOS.version >= :el_capitan
end end
def subversion_handles_most_https_certificates?
# The system Subversion is too old for some HTTPS certificates on
# older macOS versions.
MacOS.version >= :sierra
end
end end
end end