Merge pull request #7602 from MikeMcQuaid/bottle_arch_sym

bottle_arch: ensure a symbol is used when needed.
This commit is contained in:
Mike McQuaid 2020-05-19 09:27:16 +01:00 committed by GitHub
commit e254e804ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 4 deletions

View File

@ -255,7 +255,7 @@ module SharedEnvExtension
# @private
def effective_arch
if Homebrew.args.build_bottle? && Homebrew.args.bottle_arch
Homebrew.args.bottle_arch
Homebrew.args.bottle_arch.to_sym
else
Hardware.oldest_cpu
end

View File

@ -3,8 +3,10 @@
module SharedEnvExtension
# @private
def effective_arch
if Homebrew.args.build_bottle?
Homebrew.args.bottle_arch || Hardware.oldest_cpu
if Homebrew.args.build_bottle? && Homebrew.args.bottle_arch
Homebrew.args.bottle_arch.to_sym
elsif Homebrew.args.build_bottle?
Hardware.oldest_cpu
else
:native
end

View File

@ -269,7 +269,7 @@ class FormulaInstaller
return if only_deps?
if build_bottle? && (arch = Homebrew.args.bottle_arch) && !Hardware::CPU.optimization_flags.include?(arch)
if build_bottle? && (arch = Homebrew.args.bottle_arch) && !Hardware::CPU.optimization_flags.include?(arch.to_sym)
raise "Unrecognized architecture for --bottle-arch: #{arch}"
end