admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

utils/git_spec: Make example files easier to reason about

Browse Source 
- Give the files real names, like `README.md`, rather than having to
  parse the difference between "bleh" and "blah" when reading the tests.
This commit is contained in:
Issy Long 2020-07-14 00:08:06 +01:00
parent 981726c088
commit e1383c2898
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
Library/Homebrew/test/utils/git_spec.rb
View File

@ -9,33 +9,33 @@ describe Git do
HOMEBREW_CACHE.cd do HOMEBREW_CACHE.cd do
system git, "init" system git, "init"
File.open("blah.rb", "w") { |f| f.write("blah") } File.open("README.md", "w") { |f| f.write("README") }
system git, "add", HOMEBREW_CACHE/"blah.rb" system git, "add", HOMEBREW_CACHE/"README.md"
system git, "commit", "-m", "'File added'" system git, "commit", "-m", "'File added'"
@h1 = `git rev-parse HEAD` @h1 = `git rev-parse HEAD`
File.open("blah.rb", "w") { |f| f.write("brew") } File.open("README.md", "w") { |f| f.write("# README") }
system git, "add", HOMEBREW_CACHE/"blah.rb" system git, "add", HOMEBREW_CACHE/"README.md"
system git, "commit", "-m", "'written to File'" system git, "commit", "-m", "'written to File'"
@h2 = `git rev-parse HEAD` @h2 = `git rev-parse HEAD`
File.open("bleh.rb", "w") { |f| f.write("bleh") } File.open("LICENSE.txt", "w") { |f| f.write("LICENCE") }
system git, "add", HOMEBREW_CACHE/"bleh.rb" system git, "add", HOMEBREW_CACHE/"LICENSE.txt"
system git, "commit", "-m", "'File added'" system git, "commit", "-m", "'File added'"
@h3 = `git rev-parse HEAD` @h3 = `git rev-parse HEAD`
File.open("bleh.rb", "w") { |f| f.write("blehbleh") } File.open("LICENSE.txt", "w") { |f| f.write("LICENSE") }
system git, "add", HOMEBREW_CACHE/"bleh.rb" system git, "add", HOMEBREW_CACHE/"LICENSE.txt"
system git, "commit", "-m", "'written to File'" system git, "commit", "-m", "'written to File'"
end end
end end
let(:file) { "blah.rb" } let(:file) { "README.md" }
let(:file_hash1) { @h1[0..6] } let(:file_hash1) { @h1[0..6] }
let(:file_hash2) { @h2[0..6] } let(:file_hash2) { @h2[0..6] }
let(:files) { ["blah.rb", "bleh.rb"] } let(:files) { ["README.md", "LICENSE.txt"] }
let(:files_hash1) { [@h3[0..6], ["bleh.rb"]] } let(:files_hash1) { [@h3[0..6], ["LICENSE.txt"]] }
let(:files_hash2) { [@h2[0..6], ["blah.rb"]] } let(:files_hash2) { [@h2[0..6], ["README.md"]] }
describe "#last_revision_commit_of_file" do describe "#last_revision_commit_of_file" do
it "gives last revision commit when before_commit is nil" do it "gives last revision commit when before_commit is nil" do
@ -78,14 +78,14 @@ describe Git do
expect( expect(
described_class.last_revision_of_file(HOMEBREW_CACHE, described_class.last_revision_of_file(HOMEBREW_CACHE,
HOMEBREW_CACHE/file), HOMEBREW_CACHE/file),
).to eq("blah") ).to eq("README")
end end
it "returns last revision of file based on before_commit" do it "returns last revision of file based on before_commit" do
expect( expect(
described_class.last_revision_of_file(HOMEBREW_CACHE, HOMEBREW_CACHE/file, described_class.last_revision_of_file(HOMEBREW_CACHE, HOMEBREW_CACHE/file,
before_commit: "0..3"), before_commit: "0..3"),
).to eq("brew") ).to eq("# README")
end end
end end
end end