admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

os/mac/diagnostic: allow custom Ruby for devs.

Browse Source 
This avoids `brew doctor` warnings on High Sierra but in general this is
a good idea for future versions and to allow Homebrew developers to test
things out with different versions of Ruby.
This commit is contained in:
Mike McQuaid 2017-09-15 08:06:58 +01:00
parent ef60688704
commit e12d2746b6
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/extend/os/mac/diagnostic.rb
View File

@ -197,6 +197,7 @@ module Homebrew
def check_ruby_version
ruby_version = "2.0"
return if RUBY_VERSION[/\d\.\d/] == ruby_version
return if ARGV.homebrew_developer? && OS::Mac.prerelease?
<<-EOS.undent
Ruby version #{RUBY_VERSION} is unsupported on #{MacOS.version}. Homebrew

11
Library/Homebrew/test/os/mac/diagnostic_spec.rb
View File

@ -47,15 +47,10 @@ describe Homebrew::Diagnostic::Checks do
end
specify "#check_ruby_version" do
allow(MacOS).to receive(:version).and_return(OS::Mac::Version.new("10.13"))
stub_const("RUBY_VERSION", "2.3.3p222")
allow(MacOS).to receive(:version).and_return(OS::Mac::Version.new("10.12"))
stub_const("RUBY_VERSION", "1.8.6")
expect(subject.check_ruby_version)
.to match <<-EOS.undent
Ruby version 2.3.3p222 is unsupported on 10.13. Homebrew
is developed and tested on Ruby 2.0, and may not work correctly
on other Rubies. Patches are accepted as long as they don't cause breakage
on supported Rubies.
EOS
.to match "Ruby version 1.8.6 is unsupported on 10.12"
end
end