Merge pull request #5447 from jonchang/linux-doctor

doctor: check supported versions of glibc and kernel [Linux]

Library/Homebrew/diagnostic.rb

@@ -95,6 +95,16 @@ module Homebrew
         ]).freeze
       end
 
+      def please_create_pull_requests(what = "unsupported configuration")
+        <<~EOS
+          You may encounter build failures and other breakages.
+          Please create pull requests instead of asking for help on
+          Homebrew's GitHub, Discourse, Twitter or IRC. You are
+          responsible for resolving any issues you experience, as
+          you are running this #{what}.
+        EOS
+      end
+
       def check_for_installed_developer_tools
         return if DevelopmentTools.installed?
 

Library/Homebrew/extend/os/linux/diagnostic.rb

@@ -1,6 +1,8 @@
 require "tempfile"
 require "utils/shell"
 require "os/linux/diagnostic"
+require "os/linux/glibc"
+require "os/linux/kernel"
 
 module Homebrew
   module Diagnostic
@@ -59,6 +61,33 @@ module Homebrew
             echo 'umask 002' >> #{shell_profile}
         EOS
       end
+
+      def check_glibc_minimum_version
+        return unless OS::Linux::Glibc.below_minimum_version?
+
+        <<~EOS
+          Your system glibc #{OS::Linux::Glibc.system_version} is too old.
+          We only support glibc #{OS::Linux::Glibc.minimum_version} or later.
+          #{please_create_pull_requests}
+          We recommend updating to a newer version via your distribution's
+          package manager, upgrading your distribution to the latest version,
+          or changing distributions.
+        EOS
+      end
+
+      def check_kernel_minimum_version
+        return unless OS::Linux::Kernel.below_minimum_version?
+
+        <<~EOS
+          Your Linux kernel #{OS::Linux::Kernel.version} is too old.
+          We only support kernel #{OS::Linux::Kernel.minimum_version} or later.
+          You will be unable to use binary packages (bottles).
+          #{please_create_pull_requests}
+          We recommend updating to a newer version via your distribution's
+          package manager, upgrading your distribution to the latest version,
+          or changing distributions.
+        EOS
+      end
     end
   end
 end

Library/Homebrew/extend/os/mac/diagnostic.rb

@@ -60,10 +60,7 @@ module Homebrew
         <<~EOS
           You are using macOS #{MacOS.version}.
           #{who} do not provide support for this #{what}.
-          You will encounter build failures and other breakages.
+          #{please_create_pull_requests(what)}
-          Please create pull requests instead of asking for help on Homebrew's
-          GitHub, Discourse, Twitter or IRC. As you are running this #{what},
-          you are responsible for resolving any issues you experience.
         EOS
       end
 

Library/Homebrew/os/linux/glibc.rb

@@ -11,6 +11,14 @@ module OS
 
         @system_version = Version.new version
       end
+
+      def minimum_version
+        Version.new "2.12"
+      end
+
+      def below_minimum_version?
+        system_version < minimum_version
+      end
     end
   end
 end

Library/Homebrew/os/linux/kernel.rb

@@ -0,0 +1,24 @@
+module OS
+  module Linux
+    module Kernel
+      module_function
+
+      def version
+        return @version if @version
+
+        version = Utils.popen_read("uname", "-r").chomp
+        return Version::NULL unless version
+
+        @version = Version.new version
+      end
+
+      def minimum_version
+        Version.new "2.6.32"
+      end
+
+      def below_minimum_version?
+        version < minimum_version
+      end
+    end
+  end
+end

Library/Homebrew/test/os/linux/diagnostic_spec.rb

@@ -0,0 +1,17 @@
+require "diagnostic"
+
+describe Homebrew::Diagnostic::Checks do
+  specify "#check_glibc_minimum_version" do
+    allow(OS::Linux::Glibc).to receive(:below_minimum_version?).and_return(true)
+
+    expect(subject.check_glibc_minimum_version)
+      .to match(/Your system glibc .+ is too old/)
+  end
+
+  specify "#check_kernel_minimum_version" do
+    allow(OS::Linux::Kernel).to receive(:below_minimum_version?).and_return(true)
+
+    expect(subject.check_kernel_minimum_version)
+      .to match(/Your Linux kernel .+ is too old/)
+  end
+end