admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: warn once about deprecated *Formula classes

Browse Source 
GithubGistFormula inherits from ScriptFileFormula so a problem is added
for each one instead of the first only.
This commit is contained in:
Baptiste Fontaine 2016-01-21 00:12:16 +01:00
parent 3d9bc57fea
commit e0c7b38aa7
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/cmd/audit.rb
View File

@ -224,17 +224,12 @@ class FormulaAuditor
end
end
if Object.const_defined?("GithubGistFormula") && formula.class < GithubGistFormula
problem "GithubGistFormula is deprecated, use Formula instead"
classes = %w[GithubGistFormula ScriptFileFormula AmazonWebServicesFormula]
klass = classes.find do |c|
Object.const_defined?(c) && formula.class < Object.const_get(c)
end
if Object.const_defined?("ScriptFileFormula") && formula.class < ScriptFileFormula
problem "ScriptFileFormula is deprecated, use Formula instead"
end
if Object.const_defined?("AmazonWebServicesFormula") && formula.class < AmazonWebServicesFormula
problem "AmazonWebServicesFormula is deprecated, use Formula instead"
end
problem "#{klass} is deprecated, use Formula instead" if klass
end
# core aliases + tap alias names + tap alias full name