From e0a674358026c3f7db78d7705fa5efb7530ba485 Mon Sep 17 00:00:00 2001 From: apainintheneck Date: Thu, 9 Jun 2022 10:18:53 -0700 Subject: [PATCH] HOMEBREW_UPDATE_REPORT_ALL_FORMULA displays new formulae and casks Only show new formulae or casks when HOMEBREW_UPDATE_REPORT_ALL_FORMULAE environment variable is set. Stop checking for HOMEBREW_UPDATE_REPORT_ALL_FORMULAE when the key is :R, :A or :AC in ReporterHub#dump_formula_or_cask_report because that check is made redundant by the check in ReporterHub#dump. --- Library/Homebrew/cmd/update-report.rb | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/Library/Homebrew/cmd/update-report.rb b/Library/Homebrew/cmd/update-report.rb index 3bd5804128..e125a61673 100644 --- a/Library/Homebrew/cmd/update-report.rb +++ b/Library/Homebrew/cmd/update-report.rb @@ -542,7 +542,7 @@ class ReporterHub def dump(updated_formula_report: true) # Key Legend: Added (A), Copied (C), Deleted (D), Modified (M), Renamed (R) - unless Homebrew::EnvConfig.update_report_all_formulae? + if Homebrew::EnvConfig.update_report_all_formulae? dump_formula_or_cask_report :A, "New Formulae" dump_formula_or_cask_report :AC, "New Casks" dump_formula_or_cask_report :R, "Renamed Formulae" @@ -617,15 +617,13 @@ class ReporterHub # Format list items of formulae case key when :R - if report_all - name = pretty_installed(name) if installed?(name) - new_name = pretty_installed(new_name) if installed?(new_name) - "#{name} -> #{new_name}" - end + name = pretty_installed(name) if installed?(name) + new_name = pretty_installed(new_name) if installed?(new_name) + "#{name} -> #{new_name}" when :A - name if report_all && !installed?(name) + name unless installed?(name) when :AC - name.split("/").last if report_all && !cask_installed?(name) + name.split("/").last unless cask_installed?(name) when :MC name = name.split("/").last if cask_installed?(name)