admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Check for loose MacOS.version method calls

Browse Source
This commit is contained in:
Rylan Polster 2022-08-25 03:41:15 -04:00
parent a504d2c1aa
commit e08d4f9f31
No known key found for this signature in database
GPG Key ID: 46A744940CFF4D64
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Library/Homebrew/rubocops/shared/on_system_conditionals_helper.rb
View File

@ -135,6 +135,13 @@ module RuboCop
if_statement_problem(if_node, "if MacOS.version #{operator} :#{macos_version_option}",
on_system_method_string, autocorrect: autocorrect)
end
macos_version_comparison_search(body_node, os_version: macos_version_option) do |method_node|
next if if_node_is_allowed?(method_node, allowed_methods: allowed_methods, allowed_blocks: allowed_blocks)
offending_node(method_node)
problem "Don't use `#{method_node.source}`, use `on_{macos_version}` blocks instead."
end
end
end
@ -193,6 +200,10 @@ module RuboCop
(send (const (const nil? :Hardware) :CPU) %method)
PATTERN
def_node_search :macos_version_comparison_search, <<~PATTERN
(send (send (const nil? :MacOS) :version) {:== :<= :< :>= :> :!=} (sym %os_version))
PATTERN
def_node_search :if_arch_node_search, <<~PATTERN
$(if (send (const (const nil? :Hardware) :CPU) %arch) _ $_)
PATTERN