From 480a25aef9ea5ae0e1a0e206b60522bc79003908 Mon Sep 17 00:00:00 2001 From: Simon B Date: Tue, 23 Jan 2018 01:02:40 +0100 Subject: [PATCH 1/2] Add doctor and style to checklist. Ensures that contributors know about `brew doctor` and `brew style` before submitting a PR, since CI fails on `brew style` breaches. --- .github/PULL_REQUEST_TEMPLATE.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3061f42b69..a51bbb38d5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,8 @@ - [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change? - [ ] Have you added an explanation of what your changes do and why you'd like us to include them? - [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031). +- [ ] Have you successfully run `brew style` with your changes locally? +- [ ] Have you successfully run `brew doctor` with your changes locally? - [ ] Have you successfully run `brew tests` with your changes locally? ----- From 84ab3d07430d596ee83c1ca8ab894a93ea6c4a43 Mon Sep 17 00:00:00 2001 From: Simon B Date: Tue, 23 Jan 2018 01:52:37 +0100 Subject: [PATCH 2/2] don't add brew doctor --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a51bbb38d5..f7730b6e26 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,7 +3,6 @@ - [ ] Have you added an explanation of what your changes do and why you'd like us to include them? - [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031). - [ ] Have you successfully run `brew style` with your changes locally? -- [ ] Have you successfully run `brew doctor` with your changes locally? - [ ] Have you successfully run `brew tests` with your changes locally? -----