admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

tap: warn on tapping deprecated, official taps.

Browse Source 
They don't contain any formulae so tapping them will add pointless
clutter.
This commit is contained in:
Mike McQuaid 2017-04-22 16:53:48 +01:00
parent 206d6de845
commit e04cb899ac
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Library/Homebrew/official_taps.rb
View File

@ -15,3 +15,19 @@ OFFICIAL_CMD_TAPS = {
"homebrew/test-bot" => ["test-bot"], "homebrew/test-bot" => ["test-bot"],
"homebrew/services" => ["services"], "homebrew/services" => ["services"],
}.freeze }.freeze
DEPRECATED_OFFICIAL_TAPS = %w[
binary
completions
devel-only
dupes
emacs
fuse
games
gui
head-only
python
tex
versions
x11
].freeze

4
Library/Homebrew/tap.rb
View File

@ -201,6 +201,10 @@ class Tap
quiet = options.fetch(:quiet, false) quiet = options.fetch(:quiet, false)
requested_remote = options[:clone_target] || default_remote requested_remote = options[:clone_target] || default_remote
if official? && DEPRECATED_OFFICIAL_TAPS.include?(repo)
opoo "#{name} was deprecated. This tap is now empty as all its formulae were migrated."
end
if installed? if installed?
raise TapAlreadyTappedError, name unless full_clone raise TapAlreadyTappedError, name unless full_clone
raise TapAlreadyUnshallowError, name unless shallow? raise TapAlreadyUnshallowError, name unless shallow?