admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Compare patchlevels numerically rather than lexically

Browse Source 
Fixes Homebrew/homebrew#32960.
This commit is contained in:
Jack Nagel 2014-10-06 13:55:23 -05:00
parent 764d8b676d
commit dfb7657557
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/test/test_versions.rb
View File

@ -37,6 +37,7 @@ class VersionComparisonTests < Homebrew::TestCase
def test_patchlevel def test_patchlevel
assert_operator version('1.2.3-p34'), :>, version('1.2.3-p33') assert_operator version('1.2.3-p34'), :>, version('1.2.3-p33')
assert_operator version('1.2.3-p33'), :<, version('1.2.3-p34') assert_operator version('1.2.3-p33'), :<, version('1.2.3-p34')
assert_operator version('1.2.3-p10'), :>, version('1.2.3-p9')
end end
def test_HEAD def test_HEAD

2
Library/Homebrew/version.rb
View File

@ -80,7 +80,7 @@ class Version
class CompositeToken < StringToken class CompositeToken < StringToken
def rev def rev
value[/([0-9]+)/, 1] || "0" value[/[0-9]+/].to_i
end end
end end