admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #17888 from Homebrew/bin-pathname-audit-bugs

Browse Source 
rubocops/text: Allow all "#{bin}/foo" interpolated strings with spaces
This commit is contained in:
Issy Long 2024-07-28 17:44:59 +01:00 committed by GitHub
commit df6b06c57e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/text.rb
View File

@ -158,6 +158,8 @@ module RuboCop
end end
def path_starts_with_bin?(path, starts_with) def path_starts_with_bin?(path, starts_with)
return false if path.include?(" ")
path_starts_with?(path, starts_with, bin: true) path_starts_with?(path, starts_with, bin: true)
end end

2
Library/Homebrew/test/rubocops/text/strict_spec.rb
View File

@ -150,6 +150,8 @@ RSpec.describe RuboCop::Cop::FormulaAuditStrict::Text do
class Foo < Formula class Foo < Formula
test do test do
shell_output("\#{bin}/foo --version") shell_output("\#{bin}/foo --version")
assert_match "help", shell_output("\#{bin}/foo-something --help 2>&1")
assert_match "OK", shell_output("\#{bin}/foo-something_else --check 2>&1")
end end
end end
RUBY RUBY