From deb8a13a739984ac80198dec85dccf8ccba62864 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Mon, 20 Mar 2023 23:53:20 +0000 Subject: [PATCH] rubocops/cask: Make `names`, the list of method names in `on_*`, a Set Co-authored-by: Markus Reiter --- Library/Homebrew/rubocops/cask/no_overrides.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/rubocops/cask/no_overrides.rb b/Library/Homebrew/rubocops/cask/no_overrides.rb index b6d76b4fb3..57083eda71 100644 --- a/Library/Homebrew/rubocops/cask/no_overrides.rb +++ b/Library/Homebrew/rubocops/cask/no_overrides.rb @@ -33,7 +33,7 @@ module RuboCop end def on_system_stanzas(on_system) - names = [] + names = Set.new method_nodes = on_system.map(&:method_node) method_nodes.each do |node| next unless node.block_type? @@ -42,7 +42,7 @@ module RuboCop child.each_node(:send) do |send_node| next if ON_SYSTEM_METHODS.include?(send_node.method_name) - names << send_node.method_name + names.add(send_node.method_name) end end end