From de30a7844f6bf08c040ec81500e9d6d73409e3d6 Mon Sep 17 00:00:00 2001 From: Jonathan Hitchcock Date: Tue, 6 Mar 2012 17:03:39 +0200 Subject: [PATCH] 'brew doctor' provides bad example command If there are multiple dependencies missing, 'brew doctor' can suggest that you run something like: brew install autoconf libyaml autoconf, libyaml This commit improves that output. Closes Homebrew/homebrew#10720. Signed-off-by: Max Howell --- Library/Contributions/examples/brew-missing.rb | 2 +- Library/Homebrew/cmd/doctor.rb | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Library/Contributions/examples/brew-missing.rb b/Library/Contributions/examples/brew-missing.rb index b3f2875412..50fae12e4e 100755 --- a/Library/Contributions/examples/brew-missing.rb +++ b/Library/Contributions/examples/brew-missing.rb @@ -29,7 +29,7 @@ def main unless missing_deps.empty? print "#{f.name}: " if formulae_to_check.size > 1 - puts "#{missing_deps * ', '}" + puts "#{missing_deps * ' '}" end end end diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb index d87b86ec68..ad24bb958c 100644 --- a/Library/Homebrew/cmd/doctor.rb +++ b/Library/Homebrew/cmd/doctor.rb @@ -718,7 +718,9 @@ def check_missing_deps s = [] `brew missing`.each_line do |line| line =~ /(.*): (.*)/ - s << $2 unless s.include? $2 + $2.split.each do |dep| + s << dep unless s.include? dep + end end if s.length > 0 then <<-EOS.undent Some installed formula are missing dependencies.