From de15cd64204af869877ebe3c4734f5fdb0608e2c Mon Sep 17 00:00:00 2001 From: Bo Anderson Date: Wed, 18 Aug 2021 03:02:13 +0100 Subject: [PATCH] download_strategy: fix error when using custom headers with a redirect --- Library/Homebrew/download_strategy.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index e3abf6f321..9a1ac685b5 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -391,7 +391,7 @@ class CurlDownloadStrategy < AbstractFileDownloadStrategy resolved_url, _, url_time, _, is_redirection = resolve_url_basename_time_file_size(url, timeout: end_time&.remaining!) # Authorization is no longer valid after redirects - meta[:headers]&.delete_if { |header| header.first&.start_with?("Authorization") } if is_redirection + meta[:headers]&.delete_if { |header| header.start_with?("Authorization") } if is_redirection fresh = if cached_location.exist? && url_time url_time <= cached_location.mtime @@ -569,7 +569,7 @@ class CurlGitHubPackagesDownloadStrategy < CurlDownloadStrategy meta ||= {} meta[:headers] ||= [] token = Homebrew::EnvConfig.artifact_domain ? Homebrew::EnvConfig.docker_registry_token : "QQ==" - meta[:headers] << ["Authorization: Bearer #{token}"] if token.present? + meta[:headers] << "Authorization: Bearer #{token}" if token.present? super(url, name, version, meta) end