From bb57a09be024b6a158df0eece23d36740065719e Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 14 Feb 2024 08:50:24 +0000 Subject: [PATCH 1/4] Acceptable-Formulae: update static library guidance. Resulting from discussion in https://github.com/Homebrew/homebrew-core/pull/162352 --- docs/Acceptable-Formulae.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/Acceptable-Formulae.md b/docs/Acceptable-Formulae.md index bcc038fabe..e58b37d84f 100644 --- a/docs/Acceptable-Formulae.md +++ b/docs/Acceptable-Formulae.md @@ -73,11 +73,11 @@ Clang is the default C/C++ compiler on macOS (and has been for a long time). Sof We're a package manager so we want to do things like resolve dependencies and set up applications for our users. If things require too much manual intervention then they aren't useful in a package manager. -### Static libraries +### Shared vs. static libraries -In general, formulae should not ship static libraries since these cannot be updated without a rebuild of the dependant software. -If a formula gets a lot of requests to install static libraries, they may be installed by the formula. -Applications in homebrew/core linking against libraries should link against shared libraries not static versions. +In general, if formulae have to ship either shared or static libraries: they should ship shared ones. +If they can ship both, they should. +Shipping only static libraries should be avoided when possible, particularly when the formulae is depended on by other formulae since these dependents cannot be updated without a rebuild. ### Stuff that requires vendored versions of Homebrew formulae From 7e7096ba141c3324d59b18990759015114e68d6f Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 14 Feb 2024 16:14:22 +0000 Subject: [PATCH 2/4] Update docs/Acceptable-Formulae.md Co-authored-by: Ruoyu Zhong --- docs/Acceptable-Formulae.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Acceptable-Formulae.md b/docs/Acceptable-Formulae.md index e58b37d84f..c350b8954f 100644 --- a/docs/Acceptable-Formulae.md +++ b/docs/Acceptable-Formulae.md @@ -77,7 +77,7 @@ We're a package manager so we want to do things like resolve dependencies and se In general, if formulae have to ship either shared or static libraries: they should ship shared ones. If they can ship both, they should. -Shipping only static libraries should be avoided when possible, particularly when the formulae is depended on by other formulae since these dependents cannot be updated without a rebuild. +Shipping only static libraries should be avoided when possible, particularly when the formula is depended on by other formulae since these dependents cannot be updated without a rebuild. ### Stuff that requires vendored versions of Homebrew formulae From fe90e98f796b19400745004e559a55725c59132c Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 14 Feb 2024 17:09:01 +0000 Subject: [PATCH 3/4] Update docs/Acceptable-Formulae.md --- docs/Acceptable-Formulae.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Acceptable-Formulae.md b/docs/Acceptable-Formulae.md index c350b8954f..b16cc96353 100644 --- a/docs/Acceptable-Formulae.md +++ b/docs/Acceptable-Formulae.md @@ -76,7 +76,7 @@ We're a package manager so we want to do things like resolve dependencies and se ### Shared vs. static libraries In general, if formulae have to ship either shared or static libraries: they should ship shared ones. -If they can ship both, they should. +If there is interest in a static library they can ship both. Shipping only static libraries should be avoided when possible, particularly when the formula is depended on by other formulae since these dependents cannot be updated without a rebuild. ### Stuff that requires vendored versions of Homebrew formulae From 5e641f0d7276129b5c4d5c616f2cd5db2f43bca4 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 14 Feb 2024 17:32:00 +0000 Subject: [PATCH 4/4] Update docs/Acceptable-Formulae.md Co-authored-by: Ruoyu Zhong --- docs/Acceptable-Formulae.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Acceptable-Formulae.md b/docs/Acceptable-Formulae.md index b16cc96353..df6e0436fb 100644 --- a/docs/Acceptable-Formulae.md +++ b/docs/Acceptable-Formulae.md @@ -76,7 +76,7 @@ We're a package manager so we want to do things like resolve dependencies and se ### Shared vs. static libraries In general, if formulae have to ship either shared or static libraries: they should ship shared ones. -If there is interest in a static library they can ship both. +If there is interest in static libraries they can ship both. Shipping only static libraries should be avoided when possible, particularly when the formula is depended on by other formulae since these dependents cannot be updated without a rebuild. ### Stuff that requires vendored versions of Homebrew formulae