admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bottle: fix nonexistent pyc bug

Browse Source 
We were deleting pyc files *after* replace_locations_with_placeholders
and recording changed_files, meaning that some of the recorded files
were to be deleted. The correct order is the opposite.

A sample failed session: https://bot.brew.sh/job/Homebrew%20Core/10080/version=el_capitan/testReport/junit/brew-test-bot/el_capitan/bottle_buku/.
This commit is contained in:
Zhiming Wang 2016-10-25 01:44:40 -04:00
parent 79e8cdd3ed
commit dd527bfcdc
No known key found for this signature in database
GPG Key ID: BBD31D4D110044B8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/dev-cmd/bottle.rb
View File

@ -190,12 +190,12 @@ module Homebrew
changed_files = nil changed_files = nil
begin begin
keg.delete_pyc_files!
unless ARGV.include? "--skip-relocation" unless ARGV.include? "--skip-relocation"
changed_files = keg.replace_locations_with_placeholders changed_files = keg.replace_locations_with_placeholders
end end
keg.delete_pyc_files!
Tab.clear_cache Tab.clear_cache
tab = Tab.for_keg(keg) tab = Tab.for_keg(keg)
original_tab = tab.dup original_tab = tab.dup