From 17c5304cc0bf0bed6dabf2a2ad241f5fa1e06499 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sat, 17 Jun 2017 09:08:23 +0100 Subject: [PATCH 1/2] travis.yml: tweak how we handle homebrew/test-bot. On Linux this is currently blowing up for our tags so let's change the approach. --- .travis.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 81642a2d64..a5cf08cd9f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -28,8 +28,10 @@ before_install: else git fetch --unshallow; export PATH="$PWD/bin:$PATH"; - rm -rf Library/Taps/homebrew/homebrew-test-bot/.git; - mv Library/Taps/homebrew/homebrew-test-bot Library/Taps/homebrew/homebrew-core; + HOMEBREW_CORE_TAP_DIR="$(brew --repo "homebrew/core")"; + mkdir -p "$HOMEBREW_CORE_TAP_DIR"; + HOMEBREW_TEST_BOT_TAP_DIR="$(brew --repo "homebrew/test-bot")"; + ln -s "$HOMEBREW_TEST_BOT_TAP_DIR/.git" "$HOMEBREW_TEST_BOT_TAP_DIR/Formula" "$HOMEBREW_CORE_TAP_DIR"; umask 022; fi From 370eeed2e4b0a09dd7653716eb74fd5eeec96386 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Sat, 17 Jun 2017 14:01:42 +0100 Subject: [PATCH 2/2] diagnostic: quiet some CI whining. We want to be able to symlink Homebrew/test-bot to Homebrew/core on Linux for CI speed. --- Library/Homebrew/diagnostic.rb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Library/Homebrew/diagnostic.rb b/Library/Homebrew/diagnostic.rb index 05e48da21f..240e85b48a 100644 --- a/Library/Homebrew/diagnostic.rb +++ b/Library/Homebrew/diagnostic.rb @@ -760,6 +760,8 @@ module Homebrew git -C "#{coretap_path}" remote add origin #{Formatter.url("https://github.com/Homebrew/homebrew-core.git")} EOS elsif origin !~ %r{Homebrew/homebrew-core(\.git|/)?$} + return if ENV["CI"] && origin.include?("Homebrew/homebrew-test-bot") + <<-EOS.undent Suspicious #{CoreTap.instance} git origin remote found. @@ -1027,6 +1029,11 @@ module Homebrew cmd_map.reject! { |_cmd_name, cmd_paths| cmd_paths.size == 1 } return if cmd_map.empty? + if ENV["CI"] && cmd_map.keys.length == 1 && + cmd_map.keys.first == "brew-test-bot" + return + end + message = "You have external commands with conflicting names.\n" cmd_map.each do |cmd_name, cmd_paths| message += inject_file_list cmd_paths, <<-EOS.undent