From dbbf8243937e2706fc6ef1fa86abec8ba7adc13f Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Wed, 11 Mar 2020 11:51:12 +0000 Subject: [PATCH] formulary: strengthen commit URL warning. Inspired by https://github.com/Homebrew/brew/issues/7154 --- Library/Homebrew/formulary.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/formulary.rb b/Library/Homebrew/formulary.rb index 1a95711662..9ad91544dd 100644 --- a/Library/Homebrew/formulary.rb +++ b/Library/Homebrew/formulary.rb @@ -205,10 +205,11 @@ module Formulary def load_file if url =~ %r{githubusercontent.com/[\w-]+/[\w-]+/[a-f0-9]{40}(/Formula)?/([\w+-.@]+).rb} formula_name = Regexp.last_match(2) - ohai "Consider using `brew extract #{formula_name} ...`!" - puts <<~EOS + opoo <<~EOS + Unsupported installation from an commit URL! + Consider using `brew extract #{formula_name} ...` instead!" This will extract your desired #{formula_name} version to a stable tap instead of - installing from an unstable URL! + installing from a commit URL that cannnot receive updates or fixes! EOS end