admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #5371 from vitorgalvao/remove-cask-sha256-only-check

Browse Source 
Cask: Remove check on sha-only change
This commit is contained in:
Mike McQuaid 2018-12-05 20:59:17 +01:00 committed by GitHub
commit db6bdf4375
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Library/Homebrew/cask/audit.rb
View File

@ -24,7 +24,6 @@ module Cask
def run!
check_required_stanzas
check_version_and_checksum
check_version
check_sha256
check_url
@ -136,31 +135,6 @@ module Cask
add_error "at least one activatable artifact stanza is required" if installable_artifacts.empty?
end
def check_version_and_checksum
return if cask.sha256 == :no_check
return if @cask.sourcefile_path.nil?
tap = @cask.tap
return if tap.nil?
return if commit_range.nil?
previous_cask_contents = Git.last_revision_of_file(tap.path, @cask.sourcefile_path, before_commit: commit_range)
return if previous_cask_contents.empty?
begin
previous_cask = CaskLoader.load(previous_cask_contents)
return unless previous_cask.version == cask.version
return if previous_cask.sha256 == cask.sha256
add_error "only sha256 changed (see: https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/sha256.md)"
rescue CaskError => e
add_warning "Skipped version and checksum comparison. Reading previous version failed: #{e}"
end
end
def check_version
return unless cask.version