diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 0d762b2a41..d9de5e8580 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -26,7 +26,6 @@ module Cask check_version_and_checksum check_version check_sha256 - check_appcast_checkpoint check_url check_generic_artifacts check_token_conflicts @@ -214,13 +213,6 @@ module Cask add_error "cannot use the sha256 for an empty string in #{stanza}: #{empty_sha256}" end - def check_appcast_checkpoint - return unless cask.appcast - return unless cask.appcast.checkpoint - - add_error "Appcast checkpoints have been removed from Homebrew Cask" - end - def check_latest_with_appcast return unless cask.version.latest? return unless cask.appcast diff --git a/Library/Homebrew/cask/dsl/appcast.rb b/Library/Homebrew/cask/dsl/appcast.rb index 016b0ac5ce..98a0411714 100644 --- a/Library/Homebrew/cask/dsl/appcast.rb +++ b/Library/Homebrew/cask/dsl/appcast.rb @@ -1,12 +1,11 @@ module Cask class DSL class Appcast - attr_reader :uri, :checkpoint, :parameters + attr_reader :uri, :parameters def initialize(uri, **parameters) @uri = URI(uri) @parameters = parameters - @checkpoint = parameters[:checkpoint] end def to_yaml diff --git a/Library/Homebrew/test/cask/audit_spec.rb b/Library/Homebrew/test/cask/audit_spec.rb index 9d041529ec..417fc72e58 100644 --- a/Library/Homebrew/test/cask/audit_spec.rb +++ b/Library/Homebrew/test/cask/audit_spec.rb @@ -317,22 +317,6 @@ describe Cask::Audit, :cask do end end - describe "appcast checkpoint check" do - let(:error_msg) { "Appcast checkpoints have been removed from Homebrew Cask" } - - context "when the Cask does not have a checkpoint" do - let(:cask_token) { "with-appcast" } - - it { is_expected.not_to fail_with(error_msg) } - end - - context "when the Cask has a checkpoint" do - let(:cask_token) { "appcast-with-checkpoint" } - - it { is_expected.to fail_with(error_msg) } - end - end - describe "hosting with appcast checks" do let(:appcast_warning) { /please add an appcast/ } diff --git a/Library/Homebrew/test/cask/dsl/appcast_spec.rb b/Library/Homebrew/test/cask/dsl/appcast_spec.rb index e1f53ce0d6..feb42b7fb5 100644 --- a/Library/Homebrew/test/cask/dsl/appcast_spec.rb +++ b/Library/Homebrew/test/cask/dsl/appcast_spec.rb @@ -21,13 +21,5 @@ describe Cask::DSL::Appcast do expect(subject.to_yaml).to eq(yaml) end end - - context "with checkpoint in parameters" do - let(:params) { { checkpoint: "abc123" } } - - it "returns an YAML serialized array composed of the URI and parameters" do - expect(subject.to_yaml).to eq(yaml) - end - end end end diff --git a/Library/Homebrew/test/support/fixtures/cask/Casks/appcast-with-checkpoint.rb b/Library/Homebrew/test/support/fixtures/cask/Casks/appcast-with-checkpoint.rb deleted file mode 100644 index e260a0e630..0000000000 --- a/Library/Homebrew/test/support/fixtures/cask/Casks/appcast-with-checkpoint.rb +++ /dev/null @@ -1,4 +0,0 @@ -cask 'appcast-with-checkpoint' do - appcast 'https://localhost/appcast.xml', - checkpoint: 'd5b2dfbef7ea28c25f7a77cd7fa14d013d82b626db1d82e00e25822464ba19e2' -end